Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add equal_scale_axes to 2D scatter plot #40

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

mbelak-dtml
Copy link
Collaborator

No description provided.

@mbelak-dtml mbelak-dtml changed the title Feat/equal scale axes feat: add equal_scale_axes to 2D scatter plot Jul 28, 2023
@mbelak-dtml mbelak-dtml force-pushed the feat/equal-scale-axes branch 3 times, most recently from 3c8ad8d to 03d6975 Compare August 10, 2023 07:55
@mbelak-dtml mbelak-dtml self-assigned this Aug 10, 2023
@mbelak-dtml mbelak-dtml marked this pull request as ready for review August 10, 2023 07:57
Copy link
Contributor

@lukany lukany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected for interactive plots:
image
but it does not for noninteractive:
image
The code used to generate the plots:

import numpy as np
import pandas as pd
from edvart.plots import scatter_plot_2d

df = pd.DataFrame({'a': np.arange(10) * 200, 'b': np.arange(10)})

scatter_plot_2d(df=df, x='a', y='b', equal_scale_axes=True, interactive=False)

@mbelak-dtml
Copy link
Collaborator Author

It works as expected for interactive plots: image but it does not for noninteractive: image The code used to generate the plots:

import numpy as np
import pandas as pd
from edvart.plots import scatter_plot_2d

df = pd.DataFrame({'a': np.arange(10) * 200, 'b': np.arange(10)})

scatter_plot_2d(df=df, x='a', y='b', equal_scale_axes=True, interactive=False)

Thanks, fixed by using a different setting to scale the axes.

@lukany lukany added this pull request to the merge queue Aug 10, 2023
Merged via the queue into datamole-ai:main with commit 307c40a Aug 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants